feat: fetch api information from DRIFT and service_config.yaml#4567
Merged
Conversation
chingor13
requested changes
Oct 13, 2022
| api_shortname: shortName, | ||
| display_name: '', | ||
| docs_root_url: '', | ||
| launch_stage: 'LAUNCH_STAGE_UNSPECIFIED' as ReleaseLevel, |
Contributor
There was a problem hiding this comment.
Does ReleaseLevel.LAUNCH_STAGE_UNSPECIFIED work?
chingor13
reviewed
Oct 13, 2022
Contributor
Author
|
Updated cl/481195940 as well. |
chingor13
requested changes
Oct 14, 2022
chingor13
approved these changes
Oct 14, 2022
tmatsuo
reviewed
Oct 31, 2022
| serviceConfig.api_short_name = driftData.api_shortname; | ||
| } | ||
|
|
||
| if (!serviceConfig?.github_label) { |
Contributor
There was a problem hiding this comment.
In my understanding, github_label, api_shortname, documentation_uri, doc_tag_prefix are under publishing, not at the top level.
Contributor
Author
There was a problem hiding this comment.
Updated accordingly; thank you!
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the design agreed upon in
Design Doc: Providing API-specific information in owlbot-bootstrapperGrabs the service_config.yaml file, and, temporarily, fills in some pieces of information from DRIFT.