feat: create, require and read env variables for MONO_REPO_PATH, SERVICE_CONFIG_PATH, INTER_CONTAINER_VARS_PATH#4561
Merged
Merged
Conversation
…NTER_CONTAINER_VARS_PATH
chingor13
requested changes
Oct 11, 2022
chingor13
left a comment
Contributor
There was a problem hiding this comment.
This PR mostly looks fine, but it doesn't match the PR title/description. I don't see handling for env variables (I see CLI arguments being read/required).
Contributor
Author
|
@chingor13, added in the cli work (forgot to add it to the commit), PTAL |
chingor13
requested changes
Oct 12, 2022
Comment on lines
+56
to
+61
| - "--monoRepoPath" | ||
| - "$_MONO_REPO_PATH" | ||
| - "--serviceConfigPath" | ||
| - "$_SERVICE_CONFIG_PATH" | ||
| - "--interContainerVarsPath" | ||
| - "$_INTER_CONTAINER_VARS_PATH" |
Contributor
There was a problem hiding this comment.
These should be env vars, not CLI arguments.
Shouldn't the env var that the language container receive for SERVICE_CONFIG_PATH and INTER_CONTAINER_VARS_PATH be paths including the filename? I would not expect each container to have to know/specify the file name within the directory.
chingor13
approved these changes
Oct 12, 2022
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature corresponds to the work in the internal doc,
Design Doc: Providing API-specific information in owlbot-bootstrapper. We've agreed to store the paths in env variables as opposed to constants.There's a small refactor in this PR as well that corresponds to the env variables. I separated out a
writeToWellKnownFilefunction so that it corresponds to the environment variable that you want to write to, instead of being hidden in anopenABranchfunction. This makes the env variable more obvious as to where it's being used.