-
Notifications
You must be signed in to change notification settings - Fork 312
Doubling PRs when config has draft: true #1111
Copy link
Copy link
Open
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Situation:
When config file has
draft: true, pushing or merging commits tomainbranch results in Release-Please PR created correctly, but after merging that PR, another one is being created automatically with bumped minor version, and a list of all commits on the main branch up to date. Removingdraft: truefixes the issue, and extra PR does not happen, however I need to attach extra assets to the Release before it's live, to prevent automated notifications going out.cd.yml:
release-please-config.json: