Skip to content

feat: add ability to configure how many commits we retrieve when iterating through repo history#2679

Merged
ldetmer merged 2 commits intomainfrom
add-config-commit-batch
Feb 18, 2026
Merged

feat: add ability to configure how many commits we retrieve when iterating through repo history#2679
ldetmer merged 2 commits intomainfrom
add-config-commit-batch

Conversation

@ldetmer
Copy link
Copy Markdown
Contributor

@ldetmer ldetmer commented Feb 18, 2026

Release please has been consistently failing on google-cloud-node repo due to 502 errors when trying to run this query. The only way to actually have it succeed was to update the number of commits per request to be 1. We don't want to make this change for all clients as it will slow down release please run time, so lets make it configurable so node can set it to a low value.

@ldetmer ldetmer requested review from a team as code owners February 18, 2026 17:09
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 18, 2026
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to the manifest config json schema in schemas/?

Otherwise, LGTM

@chingor13
Copy link
Copy Markdown
Contributor

Can you add this to the manifest config json schema in schemas/?

Sorry, config.json, not manifest.

@ldetmer ldetmer requested a review from chingor13 February 18, 2026 18:15
@ldetmer ldetmer merged commit fee210a into main Feb 18, 2026
20 checks passed
@ldetmer ldetmer deleted the add-config-commit-batch branch February 18, 2026 19:53
landerxs07-bot

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants