-
Notifications
You must be signed in to change notification settings - Fork 536
Setting changelog-type to "github" results in a new release on any type of commit #2096
Copy link
Copy link
Closed as not planned
Closed as not planned
Copy link
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
Environment details
- OS: LInux
- Node.js version: n/a
- npm version: n/a
release-pleaseversion: Using v3 of the release-please-action so whatever version is used there.
Steps to reproduce
See #2078 for the background. I found that with any type of commit/merged PR, release-please was generating a new release, even for just chore commits, which I thought shouldn't happen.
My release-please-config.json was originally this:
{
"changelog-type": "github",
"packages": {
".": {
"release-type": "go",
"extra-files": [
"README.md",
"main.go"
]
}
}
}I had added the changelog-type setting to see what the difference was in the generated changelog, removing it so my release-please-config.json looks like this:
{
"packages": {
".": {
"release-type": "go",
"extra-files": [
"README.md",
"main.go"
]
}
}
}And now normal behaviour is restored.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.