Skip to content

Conversation

@cojenco
Copy link
Contributor

@cojenco cojenco commented Sep 23, 2022

It seems like bucket config changes may not be propagated in time, resulting in flaky system tests.

  • refactor system tests to use preconfigured fixtures
  • rearrange tests with appropriate wait and test order
  • adjust max retries

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Sep 23, 2022
@cojenco cojenco marked this pull request as ready for review September 23, 2022 19:55
@cojenco cojenco requested review from a team as code owners September 23, 2022 19:55
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@cojenco cojenco merged commit 2a6c162 into googleapis:main Sep 23, 2022
@cojenco cojenco deleted the sys-conftest branch February 1, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants