Skip to content

fix: update 'custom_time' setter to record change #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tseaver wants to merge 1 commit into from
Closed

fix: update 'custom_time' setter to record change #325

tseaver wants to merge 1 commit into from

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 24, 2020

Also, add test assertions for 'metadata' setter for the same issue.

Closes #323

@tseaver
fix: update 'custom_time' setter to record change
3a9151f 
Also, add test assertions for 'metadata' setter for the same issue.

Closes #323
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Nov 24, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 24, 2020
@tseaver
Copy link
Contributor Author

tseaver commented Nov 24, 2020

PR #323 already has the fix. I have asked the submitter to add the assertions from here.

@tseaver tseaver closed this Nov 24, 2020
@tseaver tseaver deleted the 323-custom_time-setter-patch-property branch November 24, 2020 19:32
@haim0n haim0n mentioned this pull request Nov 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tseaver