Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: remove utcnow usage#1215

Merged
cojenco merged 7 commits intogoogleapis:mainfrom
cojenco:utcnow
Feb 6, 2024
Merged

fix: remove utcnow usage#1215
cojenco merged 7 commits intogoogleapis:mainfrom
cojenco:utcnow

Conversation

@cojenco
Copy link
Copy Markdown
Contributor

@cojenco cojenco commented Feb 1, 2024

Replace datetime.utcnow which is deprecated in python 3.12

Fixes #1171
Fixes #1194

@cojenco cojenco requested a review from a team as a code owner February 1, 2024 23:36
@cojenco cojenco requested a review from a team February 1, 2024 23:36
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Feb 1, 2024
Copy link
Copy Markdown
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, LGTM, thanks!

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Feb 6, 2024
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2024
@cojenco cojenco merged commit 8d8a53a into googleapis:main Feb 6, 2024
@cojenco cojenco deleted the utcnow branch October 30, 2024 00:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DeprecationWarning warning in build log for python 3.12 datetime.datetime.utcnow() is deprecated utcnow is deprecated in python3.12

2 participants