chore: add option to delete benchmarking bucket#1038
Merged
cojenco merged 2 commits intogoogleapis:mainfrom May 18, 2023
Merged
chore: add option to delete benchmarking bucket#1038cojenco merged 2 commits intogoogleapis:mainfrom
cojenco merged 2 commits intogoogleapis:mainfrom
Conversation
andrewsg
approved these changes
May 17, 2023
Contributor
andrewsg
left a comment
There was a problem hiding this comment.
This intentionally changes the default behavior from delete to no-delete, right? Then LGTM. Thanks!
Contributor
Author
That's right, defaults to no-delete 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update benchmarking script with an added option to delete the GCS bucket or not.
With this option, the current SSB workloads will use the same bucket and avoid deletion/recreation in each run.