Skip to content

chore: update samples testing and readme#1022

Merged
andrewsg merged 4 commits intogoogleapis:mainfrom
cojenco:update-snipp
May 2, 2023
Merged

chore: update samples testing and readme#1022
andrewsg merged 4 commits intogoogleapis:mainfrom
cojenco:update-snipp

Conversation

@cojenco
Copy link
Contributor

@cojenco cojenco commented Apr 25, 2023

  • update snippets_test to gracefully handle empty env vars
  • clarify testing section in samples readme
  • add backoff retries to requester pays samples tests

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Apr 25, 2023
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2023
@cojenco cojenco marked this pull request as ready for review April 25, 2023 22:52
@cojenco cojenco requested a review from a team as a code owner April 25, 2023 22:52
@cojenco cojenco requested review from a team, MiaCY and atulep April 25, 2023 22:52
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one nit

### Run tests with nox
```
nox -s lint
nox -s py-3.7 -- snippets_test.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that 3.7 is well out of date, let's update this to 3.9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, updated

@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label May 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 1, 2023
@andrewsg andrewsg merged commit 6532e7c into googleapis:main May 2, 2023
@cojenco cojenco deleted the update-snipp branch November 16, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants