Skip to content

Incorrect comments in _signing.py #406

@DiegoQueiroz

Description

@DiegoQueiroz

In _signing.py, we can read this comment:

.. note::

    Assumes ``credentials`` implements the
    :class:`google.auth.credentials.Signing` interface. Also assumes
    ``credentials`` has a ``service_account_email`` property which
    identifies the credentials.

But the assumed property is signer_email and not service_account_email.
In nowhere a property called service_account_email is read from credentials, but signer_email is.

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: storageIssues related to the googleapis/python-storage API.priority: p2Moderately-important priority. Fix may not be included in next release.type: docsImprovement to the documentation for an API.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions