This repository was archived by the owner on Mar 31, 2026. It is now read-only.
samples: add code samples for PostgreSql dialect#836
Merged
asthamohta merged 31 commits intogoogleapis:mainfrom Oct 26, 2022
Merged
samples: add code samples for PostgreSql dialect#836asthamohta merged 31 commits intogoogleapis:mainfrom
asthamohta merged 31 commits intogoogleapis:mainfrom
Conversation
|
Here is the summary of changes. You are about to add 44 region tags.
This comment is generated by snippet-bot.
|
9c03359 to
83c023d
Compare
d2a9753 to
138ac42
Compare
8826ac2 to
43f3918
Compare
asthamohta
reviewed
Oct 12, 2022
| # format = isort + black | ||
| # | ||
|
|
||
|
|
asthamohta
reviewed
Oct 12, 2022
| OPERATION_TIMEOUT_SECONDS = 240 | ||
|
|
||
|
|
||
| # [START spanner_postgresql_create_instance] |
Contributor
There was a problem hiding this comment.
A pg instance is not required separately. You can reuse the same instance as google sql instance, and delete this test
asthamohta
reviewed
Oct 12, 2022
| database=database_name, | ||
| statements=[ | ||
| """CREATE TABLE Singers ( | ||
| SingerId bigint NOT NULL, |
Contributor
There was a problem hiding this comment.
nit: can you format this?
Contributor
There was a problem hiding this comment.
Also can you adda comment that pg is case insensitive or rename it to lower case
asthamohta
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.