Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix(deps): allow protobuf < 5.0.0#781

Merged
parthea merged 5 commits intomainfrom
allow-protobuf-4
Aug 12, 2022
Merged

fix(deps): allow protobuf < 5.0.0#781
parthea merged 5 commits intomainfrom
allow-protobuf-4

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Aug 11, 2022 •
edited
Loading

BEGIN_COMMIT_OVERRIDE
fix(deps): allow protobuf < 5.0.0
fix(deps): require proto-plus >= 1.22.0
END_COMMIT_OVERRIDE

@parthea parthea requested a review from a team as a code owner August 11, 2022 16:25
@parthea parthea requested a review from a team August 11, 2022 16:25
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/python-spanner API. labels Aug 11, 2022
@unforced unforced added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2022
@unforced
Copy link
Copy Markdown

unforced commented Aug 11, 2022 

nox > Session prerelease_deps-3.8 raised exception NameError("name 'database_dialect' is not defined")
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/nox/sessions.py", line 728, in execute
    self.func(session)
  File "/usr/local/lib/python3.10/site-packages/nox/_decorators.py", line 75, in __call__
    return self.func(*args, **kwargs)
  File "/tmpfs/src/github/python-spanner/noxfile.py", line 465, in prerelease_deps
    "SPANNER_DATABASE_DIALECT": database_dialect,
NameError: name 'database_dialect' is not defined
nox > Session prerelease_deps-3.8 failed.
cleanup

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Aug 11, 2022
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green bot commented Aug 12, 2022

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 12, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Aug 12, 2022
@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Aug 12, 2022
@parthea parthea merged commit eee5f31 into main Aug 12, 2022
@parthea parthea deleted the allow-protobuf-4 branch August 12, 2022 12:49
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@asthamohta asthamohta asthamohta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@parthea @unforced @asthamohta @yoshi-kokoro