Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

refactor: erase SQL statements parsing#679

Merged
asthamohta merged 8 commits intogoogleapis:mainfrom
MaxxleLLC:db_api_refactor
May 30, 2022
Merged

refactor: erase SQL statements parsing#679
asthamohta merged 8 commits intogoogleapis:mainfrom
MaxxleLLC:db_api_refactor

Conversation

@IlyaFaer
Copy link
Copy Markdown

@IlyaFaer IlyaFaer commented Feb 8, 2022

Continuation of an older PR: #630
All the errors fixed.

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Feb 8, 2022
@IlyaFaer IlyaFaer marked this pull request as ready for review February 10, 2022 14:04
@IlyaFaer IlyaFaer requested a review from a team as a code owner February 10, 2022 14:04
@IlyaFaer IlyaFaer requested review from a team and vi3k6i5 February 10, 2022 14:04
Copy link
Copy Markdown
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one unresolved comment from the previous PR 👍

@asthamohta asthamohta requested review from larkee and removed request for vi3k6i5 May 18, 2022 13:36
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label May 24, 2022
Copy link
Copy Markdown
Contributor

@asthamohta asthamohta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the unresolved comment by Skylar

@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2022
@asthamohta asthamohta merged commit 29b99d9 into googleapis:main May 30, 2022
@IlyaFaer IlyaFaer deleted the db_api_refactor branch May 30, 2022 09:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants