This repository was archived by the owner on Mar 31, 2026. It is now read-only.
docs: make it clear ddl_statements is a list in docs#59
Merged
larkee merged 1 commit intogoogleapis:masterfrom Apr 28, 2020
Merged
docs: make it clear ddl_statements is a list in docs#59larkee merged 1 commit intogoogleapis:masterfrom
larkee merged 1 commit intogoogleapis:masterfrom
Conversation
larkee
approved these changes
Apr 21, 2020
Contributor
larkee
left a comment
There was a problem hiding this comment.
This change is fairly minimal and straightforward so I think no bug is fine. LGTM but please run git commit --amend and edit your message to match Conventional Commit guidelines. Matching the title of this PR should work.
The ddl_statements fields expects a list of strings, not a string. This aims to make that more clear in the documentation.
Contributor
Author
|
Thanks larkee, I have updated the commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ddl_statementsfields expects alistofstrings, not astring. This aims to make that more clear in the documentation.If it is required that I open a bug for doc changes let me know and I will be happy to do so!