Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

tests: bump instance operation timeout to 240 seconds#525

Merged
larkee merged 2 commits intomasterfrom
524-bump-session-instance-creation-timeout
Aug 17, 2021
Merged

tests: bump instance operation timeout to 240 seconds#525
larkee merged 2 commits intomasterfrom
524-bump-session-instance-creation-timeout

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented Aug 16, 2021

Toward #524.

@tseaver tseaver requested review from a team and larkee August 16, 2021 16:05
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Aug 16, 2021
Likewise for samples instance creation.
@tseaver tseaver requested a review from a team as a code owner August 16, 2021 18:01
@tseaver tseaver requested a review from parthea August 16, 2021 18:01
@tseaver tseaver changed the title tests: bump instance operation timeout to 120 seconds tests: bump instance operation timeout to 240 seconds Aug 16, 2021
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2021
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Aug 16, 2021

@larkee Do we have any guidance on how long we should be expecting the backend to take making / restoring backups? The latest set of failures are showing 10 minute timeouts failing for backup samples: 3.6, 3.7, 3.8.

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Aug 16, 2021

Ugh, at this point the system-3.8 job has run for 90 minutes without completing.

@larkee
Copy link
Copy Markdown
Contributor

larkee commented Aug 17, 2021

@larkee Do we have any guidance on how long we should be expecting the backend to take making / restoring backups? The latest set of failures are showing 10 minute timeouts failing for backup samples: 3.6, 3.7, 3.8.

Unfortunately, backup creation and database restores are run as low priority so they can often take a long time if higher priority operations come in. We use 10 minute timeouts for backup creation and 20 minutes for database restores. Unfortunately, these will occasionally fail as there is no guarantee they will complete within this time.

Ugh, at this point the system-3.8 job has run for 90 minutes without completing.

This is likely related to the above point. There are currently two restores and five backup creations which may account for this long execution time as currently the backup test do not specify a timeout when waiting for a result (e.g. operation.result() rather than operation.result(1200)). I will put up a PR which will add the timeout and reduce the number of backup created by one which should prevent it for running as long.

@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2021
@larkee larkee removed the cla: yes This human has signed the Contributor License Agreement. label Aug 17, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 17, 2021
@larkee larkee merged commit 1f343a6 into master Aug 17, 2021
@larkee larkee deleted the 524-bump-session-instance-creation-timeout branch August 17, 2021 13:26
This was referenced Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants