You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
Unfortunately it makes changes to a generated file
I suppose, it would be good to add a disclaimer into the generated files. Something like Generated file. Do not edit!, otherwise it's not very obvious, unless you know what is gapic and expect to meet generated files.
As they are doing this in other clients, I (for example) have a habit to check if this line is in the file: if not, consider file isn't generated.
I suppose, it would be good to add a disclaimer into the generated files. Something like Generated file. Do not edit!, otherwise it's not very obvious, unless you know what is gapic and expect to meet generated files.
As they are doing this in other clients, I (for example) have a habit to check if this line is in the file: if not, consider file isn't generated.
That makes sense. I think I have seen that in some of the other generated files. I'm not sure why it has been removed from these ones. I'll mention it to the generator team.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yesThis human has signed the Contributor License Agreement.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41