Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: update to support the open-telemetry status code spec change#358

Merged
larkee merged 14 commits intogoogleapis:masterfrom
vi3k6i5:open_telemetry_status_update
Jun 11, 2021
Merged

fix: update to support the open-telemetry status code spec change#358
larkee merged 14 commits intogoogleapis:masterfrom
vi3k6i5:open_telemetry_status_update

Conversation

@vi3k6i5
Copy link
Copy Markdown
Contributor

@vi3k6i5 vi3k6i5 commented Jun 2, 2021 •
edited
Loading

fix: for open-telemetry status code spec change

Fixes #357 🦕

Open telemetry has changed their specs for status code. Since the open telemetry library for python is still in beta it doesn't make much sense to use/support older version of that library.

Couple of reference:

  1. 'StatusCanonicalCode' is not part of 'opentelemetry.trace.status'
  2. In memory exporter not resetting after test case ends

@vi3k6i5 vi3k6i5 requested a review from a team June 2, 2021 17:56
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 2, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Jun 2, 2021
larkee
larkee reviewed Jun 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this compatible with older versions of OpenTelemetry?

Also, the py3.6 unit tests are failing.

@vi3k6i5
Copy link
Copy Markdown
Contributor Author

vi3k6i5 commented Jun 4, 2021

Is this compatible with older versions of OpenTelemetry?

Don't think we should support any older versions of the library. As per the library doc the software is in Beta, and since they have changed their api, so not sure if we should support older versions?

Also, the py3.6 unit tests are failing.

Fixed the unit tests and system tests.

larkee
larkee reviewed Jun 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The emulator action is timing out while trying to resolve the dependencies. It seems to have an issue with opentelemetry-instrumentation == 0.22b0 in the constraints file. Using opentelemetry-instrumentation == 0.20b0 seems to resolve it but I don't know if this is a valid version..

@vi3k6i5 vi3k6i5 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2021
@vi3k6i5
Copy link
Copy Markdown
Contributor Author

vi3k6i5 commented Jun 9, 2021

The emulator action is timing out while trying to resolve the dependencies. It seems to have an issue with opentelemetry-instrumentation == 0.22b0 in the constraints file. Using opentelemetry-instrumentation == 0.20b0 seems to resolve it but I don't know if this is a valid version..

Thanks for the help, that fixed the issue. Thanks 👍

@vi3k6i5 vi3k6i5 requested a review from larkee June 9, 2021 09:11
@vi3k6i5 vi3k6i5 mentioned this pull request Jun 9, 2021
Closed
@larkee larkee changed the title fix: for open-telemetry status code spec change fix: update to support the open-telemetry status code spec change Jun 11, 2021
@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Jun 11, 2021

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@larkee larkee merged commit 0f894f1 into googleapis:master Jun 11, 2021
@tswast tswast mentioned this pull request Nov 1, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@skuruppu skuruppu Awaiting requested review from skuruppu

@thiagotnunes thiagotnunes Awaiting requested review from thiagotnunes

@c24t c24t Awaiting requested review from c24t

1 more reviewer

@larkee larkee larkee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update open telemetry tracing code according to new spec.

3 participants

@vi3k6i5 @larkee @yoshi-kokoro