This repository was archived by the owner on Mar 31, 2026. It is now read-only.
feat: add support for low-cost instances#313
Merged
larkee merged 4 commits intogoogleapis:masterfrom Jun 23, 2021
Merged
Conversation
larkee
suggested changes
Apr 22, 2021
Contributor
|
I think it's adding me as a reviewer because of the synthtool changes in |
larkee
reviewed
Apr 26, 2021
larkee
reviewed
May 6, 2021
Contributor
larkee
left a comment
There was a problem hiding this comment.
Just a couple comments to go with the proposed changes to resolve the update issue we discussed 👍
larkee
approved these changes
Jun 21, 2021
Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
larkee
reviewed
Jun 22, 2021
Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to create an instance using
processing_units.1 node = 1000 processing units. There is currently a default node count used if node count is not specified.
createandupdatenow only update processing units rather than node count, as only one can be specified.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: