This repository was archived by the owner on Mar 31, 2026. It is now read-only.
fix: support INSERT from SELECT clause with args#306
Merged
larkee merged 3 commits intogoogleapis:masterfrom Apr 15, 2021
Merged
fix: support INSERT from SELECT clause with args#306larkee merged 3 commits intogoogleapis:masterfrom
larkee merged 3 commits intogoogleapis:masterfrom
Conversation
IlyaFaer
commented
Apr 12, 2021
| # Case b) | ||
| insert_sql = sanitize_literals_for_upload(insert_sql) | ||
| return {"sql_params_list": [(insert_sql, None)]} | ||
| return {"sql_params_list": [(insert_sql, params)]} |
Author
There was a problem hiding this comment.
Looks like the previous author of the DB API didn't notice that INSERT from SELECT will be a case b), and it can include some args. Thus, passing None instead of args is not correct.
larkee
approved these changes
Apr 14, 2021
Contributor
larkee
left a comment
There was a problem hiding this comment.
LGTM. Does the docstring need updating to reflect this change?
AVaksman
approved these changes
Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spanner supports doing INSERT with values takes from a SELECT clause. However, DB API is processing such a cases incorrectly, so such a query, for example:
Will fail with a syntax error:
Fixing this bug.