This repository was archived by the owner on Mar 31, 2026. It is now read-only.
test(dbapi): add retry to autocommit sample to reduce flakiness#214
Merged
c24t merged 1 commit intogoogleapis:masterfrom Jan 27, 2021
Merged
test(dbapi): add retry to autocommit sample to reduce flakiness#214c24t merged 1 commit intogoogleapis:masterfrom
c24t merged 1 commit intogoogleapis:masterfrom
Conversation
c24t
approved these changes
Jan 27, 2021
Contributor
c24t
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #211
The autocommit sample for
dbapifails when the transaction is aborted as the implementation cannot contain retry logic. This means the test must retry onAbortederrors instead.