Conversation
c24t
left a comment
There was a problem hiding this comment.
Looks fine to me, but how come there's only a constraints file for 3.6? This project uses 3.8 as the default for tests, and doesn't run any tests for python versions >3.8.
Maybe a problem for another PR, but since the constraints files are just mechanically built from the requirements in setup.py, could synthtool keep the constraints files up to date instead of doing this manually?
Hey Chris! Right now the unit and system tests in the libraries always fetch the latest versions of dependencies. It's led to a few instances where we forgot to bump the minimum required version of some dependency (
That's a fair point, it would be nice if this were more automated. I've opened googleapis/google-cloud-python#10521 to track that. |
Add constraints file to test lower bounds. These files will not be used until the noxfile is changed in googleapis/synthtool#869.