This repository was archived by the owner on Mar 31, 2026. It is now read-only.
fix: remove erroneous timeouts for batch_create_session calls#18
Merged
larkee merged 4 commits intogoogleapis:masterfrom Feb 19, 2020
Merged
fix: remove erroneous timeouts for batch_create_session calls#18larkee merged 4 commits intogoogleapis:masterfrom
larkee merged 4 commits intogoogleapis:masterfrom
Conversation
skuruppu
reviewed
Feb 19, 2020
skuruppu
approved these changes
Feb 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the timeout that is used for getting a session from the pool is mistakenly being used for the batch_create_sessions calls that are used to initially fill pools. If the timeout is short, the call does not have time to complete and the pools fails to initialize. Removing this timeout means the default timeout for BatchCreateSessions will be used.