Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: update list_instances() to use the filter_ arg#143

Merged
larkee merged 1 commit intogoogleapis:masterfrom
larkee:fix-131
Sep 8, 2020
Merged

fix: update list_instances() to use the filter_ arg#143
larkee merged 1 commit intogoogleapis:masterfrom
larkee:fix-131

Conversation

@larkee
Copy link
Copy Markdown
Contributor

@larkee larkee commented Sep 7, 2020

Fixes #131

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2020
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 7, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 7, 2020
@larkee larkee marked this pull request as ready for review September 8, 2020 00:49
@larkee larkee requested a review from a team September 8, 2020 00:49
hengfengli
hengfengli approved these changes Sep 8, 2020
View reviewed changes
Copy link
Copy Markdown

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@larkee larkee merged commit 340028c into googleapis:master Sep 8, 2020
@wyardley
Copy link
Copy Markdown

wyardley commented Sep 8, 2020

Thanks, @larkee

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@hengfengli hengfengli hengfengli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

spanner.Client().list_instances method filter_ parameter not working

4 participants

@larkee @wyardley @hengfengli @yoshi-kokoro