Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

test: add mock server tests#1217

Merged
olavloite merged 13 commits intomainfrom
mock-server-tests
Dec 5, 2024
Merged

test: add mock server tests#1217
olavloite merged 13 commits intomainfrom
mock-server-tests

Conversation

@olavloite
Copy link
Copy Markdown
Contributor

@olavloite olavloite commented Oct 24, 2024

Adds a mock server and tests for the Python client.

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/python-spanner API. labels Oct 24, 2024
@olavloite olavloite marked this pull request as ready for review December 4, 2024 15:24
@olavloite olavloite requested a review from a team as a code owner December 4, 2024 15:24
@olavloite olavloite requested a review from a team December 4, 2024 15:24
# Generated by the gRPC Python protocol compiler plugin. DO NOT EDIT!


# Generated with the following commands:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that whenever a new admin API is introduced, this file will need to be regenerated. Alternatively, we should explore if there’s an automated way to update or refresh this file.

However, this is currently out of scope from mock server functionality and not a high priority.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Having this auto-generated would be nice. But we only really need to re-generate if there's a new feature that we actually also want to include in the mock server tests. Nothing should break if a new feature that we just don't try to use is introduced.

@olavloite olavloite merged commit 7df93ca into main Dec 5, 2024
@olavloite olavloite deleted the mock-server-tests branch December 5, 2024 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants