Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

chore: update sample instance edition to ENTERPRISE_PLUS for testing#1212

Merged
harshachinta merged 3 commits intogoogleapis:mainfrom
harshachinta:skip-edition-failure-tests
Oct 16, 2024
Merged

chore: update sample instance edition to ENTERPRISE_PLUS for testing#1212
harshachinta merged 3 commits intogoogleapis:mainfrom
harshachinta:skip-edition-failure-tests

Conversation

@harshachinta
Copy link
Copy Markdown
Contributor

@harshachinta harshachinta commented Oct 16, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@harshachinta harshachinta requested a review from a team as a code owner October 16, 2024 14:32
@harshachinta harshachinta requested review from a team and vchudnov-g October 16, 2024 14:32
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 16, 2024
@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Oct 16, 2024
@harshachinta harshachinta changed the title chore: update edition to ENTERPRISE_PLUS to test all features chore: update sample instance edition to ENTERPRISE_PLUS for testing Oct 16, 2024
@harshachinta harshachinta requested review from surbhigarg92 and removed request for vchudnov-g October 16, 2024 14:33
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 16, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 16, 2024
@harshachinta harshachinta enabled auto-merge (squash) October 16, 2024 17:53
@harshachinta harshachinta merged commit d3c6464 into googleapis:main Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hengfengli hengfengli

Labels

api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harshachinta @surbhigarg92 @hengfengli @yoshi-kokoro