Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

chore: add a new directory for archived samples of admin APIs.#1102

Merged
rahul2393 merged 2 commits intomainfrom
admin-sample-archive-dir
Feb 14, 2024
Merged

chore: add a new directory for archived samples of admin APIs.#1102
rahul2393 merged 2 commits intomainfrom
admin-sample-archive-dir

Conversation

@rahul2393
Copy link
Copy Markdown
Contributor

This is a pre-cursor step as the directory hyperlink is needed to form other documentation (release notes).

  • All archived samples will be moved to the directory samples/samples/archived

@rahul2393 rahul2393 requested a review from a team as a code owner February 14, 2024 05:21
@rahul2393 rahul2393 requested review from a team and msampathkumar February 14, 2024 05:21
@product-auto-label product-auto-label Bot added size: u Pull request is empty. api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Feb 14, 2024
@rahul2393 rahul2393 requested a review from arpan14 February 14, 2024 05:48
@rahul2393 rahul2393 requested review from arpan14 and removed request for arpan14 February 14, 2024 09:14
Copy link
Copy Markdown
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the samples are considered archived, can we omit them from this repo?

@rahul2393
Copy link
Copy Markdown
Contributor Author

rahul2393 commented Feb 14, 2024

If the samples are considered archived, can we omit them from this repo?

We will be redirecting the users to old samples in our documentation pages, and will not remove the existing public samples from this repository

Similar approach is what we are following in other libraries
googleapis/java-spanner#2886
googleapis/nodejs-spanner#1997

@rahul2393 rahul2393 merged commit b0a31e9 into main Feb 14, 2024
@rahul2393 rahul2393 deleted the admin-sample-archive-dir branch February 14, 2024 12:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. size: u Pull request is empty.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants