-
Notifications
You must be signed in to change notification settings - Fork 99
Closed
Labels
🚨This issue needs some love.This issue needs some love.api: spannerIssues related to the googleapis/python-spanner API.Issues related to the googleapis/python-spanner API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
The Kokoro tests are often failing on backup tests for unrelated changes. There are two problems:
UpdateBackupsometimes times out with DEADLINE_EXCEEDED as seen in spanner.cloud-client.backup_sample_test: test_update_backup failed GoogleCloudPlatform/python-docs-samples#3241test_list_backupsis failing due to a backup from a different test being included in the returned list forsize_bytes
The first problem can be resolved by increasing the timeout for UpdateBackup.
The second problem is difficult to replicate and the exact cause is unclear given that the tests are not run in parallel and the backups are being deleted at the end of each test. The simplest solution will be to modify the test to ensure that no backups from previous tests meet the condition.
Metadata
Metadata
Assignees
Labels
🚨This issue needs some love.This issue needs some love.api: spannerIssues related to the googleapis/python-spanner API.Issues related to the googleapis/python-spanner API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.