This repository was archived by the owner on Sep 5, 2023. It is now read-only.
chore(samples): move samples and use standard templates for testing #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enter into move-samples
busunkim96
commented
Jul 11, 2020
tdh911
reviewed
Jul 11, 2020
This was referenced Jul 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move samples into
samplesand use the separate samplesnoxfile.pyandnoxfile_config.pyfor testing.Note that I'm not deleting the samples in the existing location since that will break live samples published to cloud.google.com. Those samples will be deleted in a follow up PR after 321095338 is submitted internally.
Closes #6