Skip to content

samples: cleanup test resources#893

Merged
acocuzzo merged 6 commits intogoogleapis:mainfrom
acocuzzo:samples-cleanup
Apr 1, 2023
Merged

samples: cleanup test resources#893
acocuzzo merged 6 commits intogoogleapis:mainfrom
acocuzzo:samples-cleanup

Conversation

@acocuzzo
Copy link
Contributor

@acocuzzo acocuzzo commented Mar 31, 2023

Fixes resource clean-up in schema_test.py + subscriber_test.py

Fixes #892 🦕

@acocuzzo acocuzzo requested a review from a team as a code owner March 31, 2023 21:56
@acocuzzo acocuzzo requested review from a team and kweinmeister March 31, 2023 21:56
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Mar 31, 2023
@acocuzzo acocuzzo added owlbot:run Add this label to trigger the Owlbot post processor. and removed api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Mar 31, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 31, 2023
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 31, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 31, 2023
anguillanneuf
anguillanneuf approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + a nit.

@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 31, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 31, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. and removed size: m Pull request size is medium. labels Apr 1, 2023
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 1, 2023
@acocuzzo acocuzzo merged commit 5cde4b7 into googleapis:main Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kweinmeister kweinmeister Awaiting requested review from kweinmeister kweinmeister is a code owner automatically assigned from googleapis/python-samples-reviewers

1 more reviewer

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anguillanneuf anguillanneuf

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing test resource cleanup

2 participants

@acocuzzo @anguillanneuf