Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

Samples: Fix avro.schema.Parse in snippets#888

Merged
pradn merged 4 commits intogoogleapis:mainfrom
acocuzzo:fix-avro-parse
Mar 20, 2023
Merged

Samples: Fix avro.schema.Parse in snippets#888
pradn merged 4 commits intogoogleapis:mainfrom
acocuzzo:fix-avro-parse

Conversation

@acocuzzo
Copy link
Contributor

@acocuzzo acocuzzo commented Mar 17, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #889 🦕

@acocuzzo acocuzzo requested a review from a team as a code owner March 17, 2023 01:36
@acocuzzo acocuzzo requested review from a team and kweinmeister March 17, 2023 01:36
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Mar 17, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Mar 17, 2023
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2023
@acocuzzo acocuzzo changed the title Samples: Fix avro parse snippet Samples: Fix avro.schema.Parse in snippets Mar 17, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 17, 2023
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2023
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2023
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 20, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 20, 2023
@pradn pradn self-requested a review March 20, 2023 17:21
@pradn pradn merged commit dc6babc into googleapis:main Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kweinmeister kweinmeister Awaiting requested review from kweinmeister kweinmeister is a code owner automatically assigned from googleapis/python-samples-reviewers

@pradn pradn Awaiting requested review from pradn

1 more reviewer

@kamalaboulhosn kamalaboulhosn kamalaboulhosn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pradn pradn

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Import error in samples/snippets/schema.py

3 participants

@acocuzzo @kamalaboulhosn @pradn