Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

samples: Schema evolution#881

Merged
kamalaboulhosn merged 9 commits intogoogleapis:mainfrom
kamalaboulhosn:master
Mar 11, 2023
Merged

samples: Schema evolution#881
kamalaboulhosn merged 9 commits intogoogleapis:mainfrom
kamalaboulhosn:master

Conversation

@kamalaboulhosn
Copy link
Contributor

No description provided.

@kamalaboulhosn kamalaboulhosn requested a review from a team as a code owner March 10, 2023 22:10
@kamalaboulhosn kamalaboulhosn requested review from a team and atulep March 10, 2023 22:10
@snippet-bot
Copy link

snippet-bot bot commented Mar 10, 2023

Here is the summary of changes.

You are about to add 9 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Mar 10, 2023
@kamalaboulhosn kamalaboulhosn requested a review from acocuzzo March 10, 2023 22:11
@kamalaboulhosn kamalaboulhosn added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2023
Copy link
Contributor

@acocuzzo acocuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, these look great! My only comments are regarding exceptions.
I may do a follow-up to add more exception types to new/existing samples.

@kamalaboulhosn kamalaboulhosn added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 11, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 11, 2023
@kamalaboulhosn kamalaboulhosn added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 11, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 11, 2023
@kamalaboulhosn kamalaboulhosn merged commit eb9f233 into googleapis:main Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants