This repository was archived by the owner on Mar 9, 2026. It is now read-only.
samples: create BigQuery subscription#722
Merged
Merged
Conversation
This reverts commit 38b2a3e.
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
anguillanneuf
suggested changes
Jun 23, 2022
Contributor
There was a problem hiding this comment.
Mostly LGTM. Resource creation+deletion should be moved out of the test.
Samples tests fail due to:
> _delete_bigquery_table(dataset_id, delete_contents=True)
E TypeError: _delete_bigquery_table() got an unexpected keyword argument 'delete_contents'
anguillanneuf
approved these changes
Jul 6, 2022
acocuzzo
reviewed
Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.