DeprecationWarnings in unit tests should be trapped / asserted #367
Description
$ git log -1
commit 469ebaa3c449c881089dfc657da5902c1d031803 (HEAD -> master, origin/master, origin/HEAD)
Author: Peter Lamut <plamut@users.noreply.github.com>
Date: Fri Apr 2 09:26:10 2021 +0200
chore: regenerate GAPIC layer with latest changes (#345)
$ nox -e unit-3.8
nox > Running session unit-3.8
nox > Creating virtual environment (virtualenv) using python3.8 in .nox/unit-3-8
nox > pip install asyncmock pytest-asyncio
nox > pip install mock pytest pytest-cov
nox > pip install -e .
nox > py.test --quiet --junitxml=unit_3.8_sponge_log.xml --cov=google/cloud --cov=tests/unit --cov-append --cov-config=.coveragerc --cov-report= --cov-fail-under=0 tests/unit
........................................................................ [ 8%]
........................................................................ [ 17%]
........................................................................ [ 26%]
........................................................................ [ 34%]
........................................................................ [ 43%]
........................................................................ [ 52%]
........................................................................ [ 61%]
........................................................................ [ 69%]
........................................................................ [ 78%]
........................................................................ [ 87%]
........................................................................ [ 96%]
............................... [100%]
=============================== warnings summary ===============================
tests/unit/gapic/pubsub_v1/test_subscriber.py::test_pull_flattened
/home/tseaver/projects/agendaless/Google/src/python-pubsub/google/pubsub_v1/services/subscriber/client.py:1129: DeprecationWarning: The return_immediately flag is deprecated and should be set to False.
warnings.warn(
tests/unit/gapic/pubsub_v1/test_subscriber.py::test_pull_flattened_async
/home/tseaver/projects/agendaless/Google/src/python-pubsub/google/pubsub_v1/services/subscriber/async_client.py:947: DeprecationWarning: The return_immediately flag is deprecated and should be set to False.
warnings.warn(
...Warnings should be trapped and checked (e.g., see test_sync_pull_warning_if_return_immediately).