feat: add custom datetime format for Cloud Storage subscriptions (#1131)

gcf-owl-bot[bot] · web-flow · commit 4da67441ddab · 2024-03-26T09:38:06.000-07:00
Co-authored-by: Owl Bot &lt;gcf-owl-bot[bot]@users.noreply.github.com&gt;
diff --git a/google/pubsub_v1/types/pubsub.py b/google/pubsub_v1/types/pubsub.py
@@ -222,7 +222,7 @@ class State(proto.Enum):
                        ``gcp_service_account``.
                 PUBLISH_PERMISSION_DENIED (3):
                     Permission denied encountered while publishing to the topic.
-                    This can happen due to Pub/Sub SA has not been granted the
+                    This can happen if the Pub/Sub SA has not been granted the
                     `appropriate publish
                     permissions <https://cloud.google.com/pubsub/docs/access-control#pubsub.publisher>`__
                 STREAM_NOT_FOUND (4):
@@ -1394,6 +1394,11 @@ class CloudStorageConfig(proto.Message):
             See the `object naming
             requirements <https://cloud.google.com/storage/docs/objects#naming>`__.
             Must not end in "/".
+        filename_datetime_format (str):
+            Optional. User-provided format string specifying how to
+            represent datetimes in Cloud Storage filenames. See the
+            `datetime format
+            guidance <https://cloud.google.com/pubsub/docs/create-cloudstorage-subscription#file_names>`__.
         text_config (google.pubsub_v1.types.CloudStorageConfig.TextConfig):
             Optional. If set, message data will be
             written to Cloud Storage in text format.
@@ -1487,6 +1492,10 @@ class AvroConfig(proto.Message):
         proto.STRING,
         number=3,
     )
+    filename_datetime_format: str = proto.Field(
+        proto.STRING,
+        number=10,
+    )
     text_config: TextConfig = proto.Field(
         proto.MESSAGE,
         number=4,
