fix: Remove validation for empty text parts on Chat, this will support keeping the history in chat when the API yields back such a part.

IvanLH · copybara-github · commit 215c8524659c · 2026-01-05T15:46:55.000-08:00
PiperOrigin-RevId: 852485647
diff --git a/google/genai/chats.py b/google/genai/chats.py
@@ -35,8 +35,6 @@ def _validate_content(content: Content) -> bool:
   for part in content.parts:
     if part == Part():
       return False
-    if part.text is not None and part.text == "":
-      return False
   return True
 
 
diff --git a/google/genai/tests/chats/test_get_history.py b/google/genai/tests/chats/test_get_history.py
@@ -55,7 +55,7 @@ def mock_api_client(vertexai=False):
 
 
 @pytest.fixture
-def mock_generate_content_invalid_content():
+def mock_generate_content_with_empty_text_part():
   with mock.patch.object(
       models.Models, 'generate_content'
   ) as mock_generate_content:
@@ -84,7 +84,7 @@ def mock_generate_content_empty_content():
 
 
 @pytest.fixture
-def mock_generate_content_stream_invalid_content():
+def mock_generate_content_stream_with_empty_text_part():
   with mock.patch.object(
       models.Models, 'generate_content_stream'
   ) as mock_generate_content:
@@ -95,7 +95,8 @@ def mock_generate_content_stream_invalid_content():
                     content=types.Content(
                         role='model',
                         parts=[types.Part(text='')],
-                    )
+                    ),
+                    finish_reason=types.FinishReason.STOP,
                 )
             ]
         )
@@ -481,7 +482,7 @@ def test_history_with_invalid_turns():
   assert chat.get_history(curated=True) == curated_history
 
 
-def test_chat_with_invalid_content(mock_generate_content_invalid_content):
+def test_chat_with_empty_text_part(mock_generate_content_with_empty_text_part):
   models_module = models.Models(mock_api_client)
   chats_module = chats.Chats(modules=models_module)
   chat = chats_module.create(model='gemini-2.5-flash')
@@ -496,7 +497,7 @@ def test_chat_with_invalid_content(mock_generate_content_invalid_content):
       ),
   ]
   assert chat.get_history() == expected_comprehensive_history
-  assert not chat.get_history(curated=True)
+  assert chat.get_history(curated=True) == expected_comprehensive_history
 
 
 def test_chat_with_empty_content(mock_generate_content_empty_content):
@@ -517,8 +518,8 @@ def test_chat_with_empty_content(mock_generate_content_empty_content):
   assert not chat.get_history(curated=True)
 
 
-def test_chat_stream_with_invalid_content(
-    mock_generate_content_stream_invalid_content,
+def test_chat_stream_with_empty_text_part(
+    mock_generate_content_stream_with_empty_text_part,
 ):
   models_module = models.Models(mock_api_client)
   chats_module = chats.Chats(modules=models_module)
@@ -536,7 +537,7 @@ def test_chat_stream_with_invalid_content(
       ),
   ]
   assert chat.get_history() == expected_comprehensive_history
-  assert not chat.get_history(curated=True)
+  assert chat.get_history(curated=True) == expected_comprehensive_history
 
 
 def test_chat_stream_with_empty_content(
diff --git a/google/genai/tests/chats/test_validate_response.py b/google/genai/tests/chats/test_validate_response.py
@@ -53,7 +53,7 @@ def test_validate_response_part_with_empty_text():
       ]
   )
 
-  assert not _validate_response(response)
+  assert _validate_response(response)
 
 
 def test_validate_response_part_with_text():

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ def test_validate_response_part_with_empty_text():`
`53`	`53`	`]`
`54`	`54`	`)`
`55`	`55`
`56`		`- assert not _validate_response(response)`
	`56`	`+ assert _validate_response(response)`
`57`	`57`
`58`	`58`
`59`	`59`	`def test_validate_response_part_with_text():`