This repository was archived by the owner on Mar 2, 2026. It is now read-only.
This repository was archived by the owner on Mar 2, 2026. It is now read-only.
google.cloud.firestore lacks packaged typing #447
Description
Hi.
google.cloud.firestore does not have types via PEP561
google.cloud.firestore_v1 and friends do.
Per the PEP:
This PEP does not support distributing typing information as part of module-only distributions. The code should be refactored into a package-based distribution and indicate that the package supports typing as described above.
You'll have to refactor firestore.py into a directory structure
google/
cloud/
firestore/
__init__.py
py.typed
Repro steps:
# ~/test/test.py
# firestore doesn't have py.typed yet - only firestore_v1 has
from google.cloud.firestore import AsyncClient
from google.cloud.firestore_v1 import AsyncClientpython3 -m venv venv
source venv/bin/activate
pip install google-cloud-firestore
# or `pip install -e ~/src/python-firestore` for a local checkout
mypy --python-executable=venv/bin/python test.py