Skip to content

refactor: Refactor of hocr functions and fixing lost changes #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
holtskinner merged 6 commits into from
Jul 7, 2023
Merged

refactor: Refactor of hocr functions and fixing lost changes #137

holtskinner merged 6 commits into from
Jul 7, 2023

Conversation

@holtskinner
Copy link
Member

@holtskinner holtskinner commented Jun 30, 2023 •
edited
Loading

  • Added Sample for hocr export
    • Fixed issue where Jinja Template wouldn't work in installed library.

@holtskinner
refactor: Reorganize hocr functions
88ed653 
- Use more jinja templating instead of hardcoding strings
- Simplified bounding box function
- Changed parameter name for `_get_hocr_bounding_box` to `page_dimension` for more clarity.
@holtskinner
samples: Added sample for convert to hocr
3afb9e7
@holtskinner
refactor: Reordering of classes in page.py
8366993
@holtskinner
refactor: Re-added refactoring to remove extra get_*() methods in p…
f5d5bc0 
…age.py

- Added in #110 Lost in Merge
@holtskinner holtskinner requested review from a team as code owners June 30, 2023 20:40
@holtskinner holtskinner requested a review from kweinmeister June 30, 2023 20:40
@snippet-bot
Copy link

snippet-bot bot commented Jun 30, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jun 30, 2023
@holtskinner holtskinner added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 30, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 30, 2023
@holtskinner
Copy link
Member Author

holtskinner commented Jun 30, 2023 •
edited
Loading

Note - the error for the Samples might actually need fixing in the document.py wrapper. Not sure if the paths all line up correctly for the template when using the compiled library

Update: It did

@holtskinner
fix: Moved templates directory into package.
7fcd137 
- Required for template to work in installed library
@holtskinner holtskinner added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2023
@holtskinner holtskinner added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2023
@holtskinner holtskinner added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2023
@galz10 galz10 requested review from dizcology and removed request for kweinmeister July 5, 2023 16:39
@holtskinner holtskinner merged commit 4f7ba1b into main Jul 7, 2023
@holtskinner holtskinner deleted the hocr-exp branch July 7, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dizcology dizcology dizcology approved these changes

@galz10 galz10 galz10 approved these changes

Assignees

@dizcology dizcology

@galz10 galz10

Labels

size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@holtskinner @dizcology @galz10 @yoshi-kokoro