This repository was archived by the owner on Dec 17, 2023. It is now read-only.
ci: opt in to use multiple projects #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2cdd060 to
ccd66cd
Compare
busunkim96
suggested changes
Nov 12, 2021
ccd66cd to
0a58b76
Compare
kurtisvg
suggested changes
Nov 12, 2021
Contributor
kurtisvg
left a comment
There was a problem hiding this comment.
Looks like the tests are failing. Are there resources that need to be set up in the new projects?
Contributor
Author
|
Yes. I've filed a bug here to request help. |
Contributor
Yea there are resources you need to add for the new projects, i don't think that this will solve the quota issue due to how Dialogflow ES works, this issue usually occurs when there are multiple PRs running at the same time. Since they're all referencing the same project then you get the quota limit, but this will also happen if you use multiple projects because the multiple projects will be called at the same time. |
kurtisvg
approved these changes
Nov 16, 2021
Contributor
Author
|
@busunkim96 Please could you review/approve? |
busunkim96
approved these changes
Nov 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.