Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

chore: add SPOT to enum of preemptibility#507

Closed
tqtensor wants to merge 2 commits intogoogleapis:mainfrom
tqtensor:main
Closed

chore: add SPOT to enum of preemptibility#507
tqtensor wants to merge 2 commits intogoogleapis:mainfrom
tqtensor:main

Conversation

@tqtensor
Copy link
Copy Markdown

@tqtensor tqtensor commented Dec 17, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #506 🦕

Here is a simple test to create Dataproc cluster with SPOT instance. Colab

@tqtensor tqtensor requested a review from a team as a code owner December 17, 2022 00:56
@tqtensor tqtensor requested a review from a team December 17, 2022 00:56
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: dataproc Issues related to the googleapis/python-dataproc API. labels Dec 17, 2022
@tqtensor tqtensor changed the title Add SPOT to enum of preemptibility chore: add SPOT to enum of preemptibility Dec 17, 2022
@sudohainguyen
Copy link
Copy Markdown

sudohainguyen commented Dec 17, 2022

+1

1 similar comment
@binhflow
Copy link
Copy Markdown

binhflow commented Dec 27, 2022

+1

@tqtensor tqtensor marked this pull request as draft January 5, 2023 03:02
@tqtensor
Copy link
Copy Markdown
Author

tqtensor commented Jan 5, 2023

Dear @parthea and @msampathkumar,

I am sorry to bother you all, but I don't know anyone to contact about this issue. This PR is pretty simple; I want to add the SPOT instance type to the enum of preemptibility to allow the Dataproc client to create a cluster with SPOT machines.

Who else should I contact to review this PR? If you know them, please tag them here.

Thank you.

@tqtensor tqtensor marked this pull request as ready for review January 5, 2023 03:05
@parthea parthea self-assigned this Jan 5, 2023
@parthea
Copy link
Copy Markdown
Contributor

parthea commented Jan 5, 2023

Googlers see cl/499867716 with proposal to update https://github.com/googleapis/googleapis/tree/master/google/cloud/dataproc/v1

@parthea parthea mentioned this pull request Jan 23, 2023
Merged
1 task
@parthea parthea closed this in #512 Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@parthea parthea

Labels

api: dataproc Issues related to the googleapis/python-dataproc API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow creating dataproc secondary workers as spot instances.

4 participants

@tqtensor @sudohainguyen @binhflow @parthea