Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 12, 2021

No description provided.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 12, 2021
@tseaver tseaver requested a review from tmatsuo November 9, 2021 18:40
@tseaver tseaver marked this pull request as ready for review November 9, 2021 18:40
@tseaver tseaver requested a review from a team as a code owner November 9, 2021 18:40
@tseaver tseaver force-pushed the ci-prototype-github-actions branch from 5c50c01 to 469ff9e Compare November 17, 2021 21:00
@tseaver
Copy link
Contributor Author

tseaver commented Nov 17, 2021

@tmatsuo Do we need to be disabling the tests run via GH Actions in the Kokoro build?

@tmatsuo
Copy link

tmatsuo commented Nov 23, 2021

@tseaver

Do we need to be disabling the tests run via GH Actions in the Kokoro build?

Sorry what do you mean?

@tseaver
Copy link
Contributor Author

tseaver commented Nov 23, 2021

@tmatsuo If we are running lint / unit tests / coverage / mypy via GH Actions, should we skip running them on Kokoro, restricting it to only those jobs which need secrets?

@tmatsuo
Copy link

tmatsuo commented Nov 29, 2021

@tseaver Yes, it makes sense. Tell us which Kokoro job we should disable.
@parthea FYI

@tseaver
Copy link
Contributor Author

tseaver commented Nov 30, 2021

@tmatsuo

Yes, it makes sense. Tell us which Kokoro job we should disable.

For this repo, the main Kokoro build is completely covered by the GH Actions: there are no systests or samples being run. We would also need to work out the spellings to make those actions required in .kokoro/sync-repo-settings.yaml.

@tseaver tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 7, 2021
@tseaver
Copy link
Contributor Author

tseaver commented Dec 7, 2021

@parthea I added a sync_repo_settings.py here, and configured it to make the GH Actions required. However, that change isn't made during the PR review process: it gets applied by the repo automation bot only after the PR merges. Dropping the Kokoro job (but not Kokoro docs-presubmit) would need to happen in the internal google3 repo, I think -- while we're at it, we could drop the Samples jobs, too -- this repo has none.

@tseaver tseaver requested a review from parthea December 7, 2021 19:09
@tseaver tseaver merged commit 3799fdb into main Dec 7, 2021
@tseaver tseaver deleted the ci-prototype-github-actions branch December 7, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants