Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

chore: update templated files#986

Merged
parthea merged 15 commits into
mainfrom
parthea-patch-1
Jul 17, 2024
Merged

chore: update templated files#986
parthea merged 15 commits into
mainfrom
parthea-patch-1

Conversation

@parthea

@parthea parthea commented Jul 5, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@parthea parthea requested review from a team July 5, 2024 14:41
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Jul 5, 2024
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Jul 5, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2024
@parthea parthea marked this pull request as draft July 5, 2024 15:30
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jul 5, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2024
@parthea parthea marked this pull request as ready for review July 5, 2024 16:16
@gcf-owl-bot gcf-owl-bot Bot requested a review from a team as a code owner July 5, 2024 16:18
@gcf-owl-bot gcf-owl-bot Bot requested a review from kweinmeister July 5, 2024 16:18
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: s Pull request size is small. labels Jul 5, 2024
daniel-sanche
daniel-sanche suggested changes Jul 17, 2024
View reviewed changes

@daniel-sanche daniel-sanche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is removing some important owlbot customizations. I'll push a fix

@parthea

parthea commented Jul 17, 2024

Copy link
Copy Markdown
Contributor Author

Good catch ! I see that now

parthea
parthea commented Jul 17, 2024
View reviewed changes
Comment thread noxfile.py
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 17, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 17, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 17, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 17, 2024
@parthea parthea merged commit 481c8d6 into main Jul 17, 2024
@parthea parthea deleted the parthea-patch-1 branch July 17, 2024 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kweinmeister kweinmeister Awaiting requested review from kweinmeister kweinmeister is a code owner automatically assigned from googleapis/python-samples-reviewers

1 more reviewer

@daniel-sanche daniel-sanche daniel-sanche approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mutianf mutianf

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parthea @daniel-sanche @mutianf