Skip to content

chore(samples): harden 'tableadmin' samples against 429/503 errors #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 2 commits into from
Oct 20, 2021
Merged

chore(samples): harden 'tableadmin' samples against 429/503 errors #418

tseaver merged 2 commits into from
Oct 20, 2021

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 31, 2021

Closes #417.

@tseaver tseaver requested a review from a team as a code owner August 31, 2021 20:42
@product-auto-label product-auto-label bot added api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. labels Aug 31, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2021
@tseaver tseaver force-pushed the 417-harden-tableadmin-sample-429-503 branch from 19cc257 to 97824a4 Compare September 14, 2021 21:19
chrisrossi
chrisrossi approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tseaver
Copy link
Contributor Author

tseaver commented Sep 27, 2021

Needs review from a member of @googleapis/python-samples-owners or maybe @googleapis/api-bigtable.

@tseaver tseaver merged commit 2841442 into main Oct 20, 2021
@tseaver tseaver deleted the 417-harden-tableadmin-sample-429-503 branch October 20, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolea2 kolea2 kolea2 approved these changes

@billyjacobson billyjacobson Awaiting requested review from billyjacobson

+2 more reviewers

@chrisrossi chrisrossi chrisrossi approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'tableadmin_test.test_run_table_operations' sample fails with 503 UNAVAILABLE

4 participants

@tseaver @chrisrossi @busunkim96 @kolea2