Skip to content

chore(samples): add EC check to metricscalar instance setup #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 3 commits into from
Sep 30, 2021
Merged

chore(samples): add EC check to metricscalar instance setup #395

tseaver merged 3 commits into from
Sep 30, 2021

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 22, 2021

Closes #394.

@tseaver tseaver requested a review from a team as a code owner July 22, 2021 18:20
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2021
@product-auto-label product-auto-label bot added api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. labels Jul 22, 2021
@tseaver tseaver mentioned this pull request Jul 23, 2021
Merged
@tseaver tseaver requested a review from leahecole August 31, 2021 18:15
@tseaver tseaver force-pushed the 394-unflake-metricscaler-setup branch from 1bb59c6 to efa4e06 Compare September 14, 2021 21:19
chrisrossi
chrisrossi approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tseaver
Copy link
Contributor Author

tseaver commented Sep 27, 2021

Needs review from a member of @googleapis/python-samples-owners or maybe @googleapis/api-bigtable.

@tseaver tseaver merged commit d649ca7 into main Sep 30, 2021
@tseaver tseaver deleted the 394-unflake-metricscaler-setup branch September 30, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@busunkim96 busunkim96 Awaiting requested review from busunkim96

@kolea2 kolea2 Awaiting requested review from kolea2

@leahecole leahecole Awaiting requested review from leahecole

2 more reviewers

@chrisrossi chrisrossi chrisrossi approved these changes

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@crwilcox crwilcox

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

metricscaler sample: 'test_scale_bigtable' fails in setup with NotFound

3 participants

@tseaver @chrisrossi @crwilcox