Skip to content

feat: add keep alive timeout #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crwilcox merged 2 commits into from
Feb 9, 2021
Merged

feat: add keep alive timeout #182

crwilcox merged 2 commits into from
Feb 9, 2021

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Dec 4, 2020 •
edited
Loading

Fixes #181

Added grpc.keepalive_time_ms and grpc.keepalive_timeout_ms for an emulator as it used insecure channel.

Clients are gapic generated client so need to add in respective files:

1:

python-bigtable/google/cloud/bigtable_v2/gapic/transports/bigtable_grpc_transport.py

Lines 67 to 74 in 9b380a3

if channel is None:
channel = self.create_channel(
address=address,
credentials=credentials,
options={
"grpc.max_send_message_length": -1,
"grpc.max_receive_message_length": -1,
}.items(),

2 :

python-bigtable/google/cloud/bigtable_admin_v2/gapic/transports/bigtable_instance_admin_grpc_transport.py

Lines 71 to 79 in 9b380a3

if channel is None:
channel = self.create_channel(
address=address,
credentials=credentials,
options={
"grpc.max_send_message_length": -1,
"grpc.max_receive_message_length": -1,
}.items(),
)

3:

python-bigtable/google/cloud/bigtable_admin_v2/gapic/transports/bigtable_table_admin_grpc_transport.py

Lines 71 to 79 in 9b380a3

if channel is None:
channel = self.create_channel(
address=address,
credentials=credentials,
options={
"grpc.max_send_message_length": -1,
"grpc.max_receive_message_length": -1,
}.items(),
)

@HemangChothani HemangChothani requested a review from a team as a code owner December 4, 2020 13:39
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2020
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Dec 4, 2020
@kolea2
Copy link
Collaborator

kolea2 commented Dec 10, 2020

CC @sushanb

kolea2
kolea2 reviewed Dec 10, 2020
View reviewed changes
@kolea2
Copy link
Collaborator

kolea2 commented Dec 29, 2020

Is there a way to override the channel settings in the handwritten layer?

@HemangChothani
Copy link
Contributor Author

HemangChothani commented Dec 30, 2020

Yes, I think so. We need to create channel explicitly in handwritten client for all the classes which mentioned above and then create a respective transport class object and pass as an argument for all the classes,so gapic class doesn't create or override the transport class object.

@crwilcox crwilcox merged commit e9637cb into googleapis:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolea2 kolea2 kolea2 left review comments

@tseaver tseaver Awaiting requested review from tseaver

+1 more reviewer

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add keepalive in grpc channel for Bigtable client

3 participants

@HemangChothani @kolea2 @crwilcox