This repository was archived by the owner on Apr 1, 2026. It is now read-only.
chore(tests): clean up sample test tables#1030
Merged
Merged
Conversation
9ea5bc2 to
9dbe9c8
Compare
|
Here is the summary of changes. You are about to add 23 region tags.
You are about to delete 23 region tags.
This comment is generated by snippet-bot.
|
bhshkh
approved these changes
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the sample tests are creating new tables for each test run, and not always cleaning them up properly. This causes tests to start failing when we hit the 1000 table per instance limit
This PR attempts to fix all the clean-up code to always run, even if there are errors in the tests. We do this using context managers and try/except statements