Skip to content

Commit a4d551e

Browse files
gcf-owl-bot[bot]gcf-owl-bot[bot]
authored
feat: Add support for Cloud Bigtable Request Priorities in App Profiles (#871)
* feat: Add support for Cloud Bigtable Request Priorities in App Profiles PiperOrigin-RevId: 571158646 Source-Link: googleapis/googleapis@bc3c83b Source-Link: googleapis/googleapis-gen@93366e8 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTMzNjZlODRlNGU2ODYxZTJlNTgwZWIwMDA3MjFkOTliZjU0YTBhNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent e5af359 commit a4d551e

File tree

2 files changed

+76
-1
lines changed

2 files changed

+76
-1
lines changed

‎google/cloud/bigtable_admin_v2/types/instance.py‎

Lines changed: 64 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ class AutoscalingTargets(proto.Message):
173173
The storage utilization that the Autoscaler should be trying
174174
to achieve. This number is limited between 2560 (2.5TiB) and
175175
5120 (5TiB) for a SSD cluster and between 8192 (8TiB) and
176-
16384 (16TiB) for an HDD cluster; otherwise it will return
176+
16384 (16TiB) for an HDD cluster, otherwise it will return
177177
INVALID_ARGUMENT error. If this value is set to 0, it will
178178
be treated as if it were set to the default value: 2560 for
179179
SSD, 8192 for HDD.
@@ -419,8 +419,43 @@ class AppProfile(proto.Message):
419419
Use a single-cluster routing policy.
420420
421421
This field is a member of `oneof`_ ``routing_policy``.
422+
priority (google.cloud.bigtable_admin_v2.types.AppProfile.Priority):
423+
This field has been deprecated in favor of
424+
``standard_isolation.priority``. If you set this field,
425+
``standard_isolation.priority`` will be set instead.
426+
427+
The priority of requests sent using this app profile.
428+
429+
This field is a member of `oneof`_ ``isolation``.
430+
standard_isolation (google.cloud.bigtable_admin_v2.types.AppProfile.StandardIsolation):
431+
The standard options used for isolating this
432+
app profile's traffic from other use cases.
433+
434+
This field is a member of `oneof`_ ``isolation``.
422435
"""
423436

437+
class Priority(proto.Enum):
438+
r"""Possible priorities for an app profile. Note that higher
439+
priority writes can sometimes queue behind lower priority writes
440+
to the same tablet, as writes must be strictly sequenced in the
441+
durability log.
442+
443+
Values:
444+
PRIORITY_UNSPECIFIED (0):
445+
Default value. Mapped to PRIORITY_HIGH (the legacy behavior)
446+
on creation.
447+
PRIORITY_LOW (1):
448+
No description available.
449+
PRIORITY_MEDIUM (2):
450+
No description available.
451+
PRIORITY_HIGH (3):
452+
No description available.
453+
"""
454+
PRIORITY_UNSPECIFIED = 0
455+
PRIORITY_LOW = 1
456+
PRIORITY_MEDIUM = 2
457+
PRIORITY_HIGH = 3
458+
424459
class MultiClusterRoutingUseAny(proto.Message):
425460
r"""Read/write requests are routed to the nearest cluster in the
426461
instance, and will fail over to the nearest cluster that is
@@ -466,6 +501,22 @@ class SingleClusterRouting(proto.Message):
466501
number=2,
467502
)
468503

504+
class StandardIsolation(proto.Message):
505+
r"""Standard options for isolating this app profile's traffic
506+
from other use cases.
507+
508+
Attributes:
509+
priority (google.cloud.bigtable_admin_v2.types.AppProfile.Priority):
510+
The priority of requests sent using this app
511+
profile.
512+
"""
513+
514+
priority: "AppProfile.Priority" = proto.Field(
515+
proto.ENUM,
516+
number=1,
517+
enum="AppProfile.Priority",
518+
)
519+
469520
name: str = proto.Field(
470521
proto.STRING,
471522
number=1,
@@ -490,6 +541,18 @@ class SingleClusterRouting(proto.Message):
490541
oneof="routing_policy",
491542
message=SingleClusterRouting,
492543
)
544+
priority: Priority = proto.Field(
545+
proto.ENUM,
546+
number=7,
547+
oneof="isolation",
548+
enum=Priority,
549+
)
550+
standard_isolation: StandardIsolation = proto.Field(
551+
proto.MESSAGE,
552+
number=11,
553+
oneof="isolation",
554+
message=StandardIsolation,
555+
)
493556

494557

495558
class HotTablet(proto.Message):

‎tests/unit/gapic/bigtable_admin_v2/test_bigtable_instance_admin.py‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3524,6 +3524,7 @@ def test_create_app_profile(request_type, transport: str = "grpc"):
35243524
name="name_value",
35253525
etag="etag_value",
35263526
description="description_value",
3527+
priority=instance.AppProfile.Priority.PRIORITY_LOW,
35273528
)
35283529
response = client.create_app_profile(request)
35293530

@@ -3793,6 +3794,7 @@ def test_get_app_profile(request_type, transport: str = "grpc"):
37933794
name="name_value",
37943795
etag="etag_value",
37953796
description="description_value",
3797+
priority=instance.AppProfile.Priority.PRIORITY_LOW,
37963798
)
37973799
response = client.get_app_profile(request)
37983800

@@ -9323,6 +9325,8 @@ def test_create_app_profile_rest(request_type):
93239325
"cluster_id": "cluster_id_value",
93249326
"allow_transactional_writes": True,
93259327
},
9328+
"priority": 1,
9329+
"standard_isolation": {"priority": 1},
93269330
}
93279331
request = request_type(**request_init)
93289332

@@ -9333,6 +9337,7 @@ def test_create_app_profile_rest(request_type):
93339337
name="name_value",
93349338
etag="etag_value",
93359339
description="description_value",
9340+
priority=instance.AppProfile.Priority.PRIORITY_LOW,
93369341
)
93379342

93389343
# Wrap the value into a proper Response obj
@@ -9550,6 +9555,8 @@ def test_create_app_profile_rest_bad_request(
95509555
"cluster_id": "cluster_id_value",
95519556
"allow_transactional_writes": True,
95529557
},
9558+
"priority": 1,
9559+
"standard_isolation": {"priority": 1},
95539560
}
95549561
request = request_type(**request_init)
95559562

@@ -9655,6 +9662,7 @@ def test_get_app_profile_rest(request_type):
96559662
name="name_value",
96569663
etag="etag_value",
96579664
description="description_value",
9665+
priority=instance.AppProfile.Priority.PRIORITY_LOW,
96589666
)
96599667

96609668
# Wrap the value into a proper Response obj
@@ -10283,6 +10291,8 @@ def test_update_app_profile_rest(request_type):
1028310291
"cluster_id": "cluster_id_value",
1028410292
"allow_transactional_writes": True,
1028510293
},
10294+
"priority": 1,
10295+
"standard_isolation": {"priority": 1},
1028610296
}
1028710297
request = request_type(**request_init)
1028810298

@@ -10489,6 +10499,8 @@ def test_update_app_profile_rest_bad_request(
1048910499
"cluster_id": "cluster_id_value",
1049010500
"allow_transactional_writes": True,
1049110501
},
10502+
"priority": 1,
10503+
"standard_isolation": {"priority": 1},
1049210504
}
1049310505
request = request_type(**request_init)
1049410506

0 commit comments

Comments
 (0)