Skip to content

Conversation

@HemangChothani
Copy link
Contributor

Fixes #65

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2020
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching that. 👍

@HemangChothani
Copy link
Contributor Author

The failed test has nothing to do with the changes here.

@plamut
Copy link
Contributor

plamut commented Mar 25, 2020

Indeed, and I will temporarily disable it (as per recent discussion) until that issue gets fixed.

@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 26, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 26, 2020
@plamut
Copy link
Contributor

plamut commented Mar 26, 2020

@HemangChothani Please just update the branch so that we can merge this, thanks!

@plamut plamut merged commit 26c6204 into googleapis:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bigquery: Model reference repr seems wrong for model_id

4 participants