This repository was archived by the owner on Mar 6, 2026. It is now read-only.
bug: updates __eq__ comparison on TableConstraint#2274
Merged
chalmerlowe merged 5 commits intomainfrom Sep 3, 2025
Merged
Conversation
iennae
approved these changes
Sep 3, 2025
iennae
left a comment
There was a problem hiding this comment.
LTGM; subtle logic issue and the improved tests would catch this problem and fully test edge cases. Thanks!
tswast
approved these changes
Sep 3, 2025
Collaborator
Author
|
Fixes #2174 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
__eq__()dunder method onTableConstraints.Previously it would give incorrect results (e.g. a return value of
Noneinstead ofFalse)Fixes #2263 🦕