This repository was archived by the owner on Dec 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
fix: remove unnecessary double quotes #229
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary double quotes (i.e: "...must" "be set...") in `google/cloud/automl_v1beta1/services/tables/tables_client.py`
tables_client.pytables_client.py
tables_client.py
busunkim96
approved these changes
Aug 17, 2021
Contributor
|
Thank you for the patch @santiagotoscanini! |
Contributor
|
@busunkim96 Is |
Author
Does the CI fail because of the |
Contributor
|
@santiagotoscanini Yes, it does. Can you run |
Author
|
@tseaver I pushed the file, but the CI seems to be stuck (~3 hours) |
Contributor
@pytest.fixture(scope="function")
def operation_id():
client = automl.AutoMlClient()
project_location = f"projects/{PROJECT_ID}/locations/us-central1"
generator = client._transport.operations_client.list_operations(
project_location, filter_=""
).pages
page = next(generator)
> operation = page.next()
E AttributeError: 'Page' object has no attribute 'next'
get_operation_status_test.py:34: AttributeErrorLooks unrelated to this change, has there been a breaking change that came in recently? Or did this flake? |
Contributor
|
@dandhlee the Flakybot logged new issues for this failure today: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: automl
Issues related to the googleapis/python-automl API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: remove unnecessary double quotes
Remove unnecessary double quotes (i.e: "...must" "be set...")
in
google/cloud/automl_v1beta1/services/tables/tables_client.pyFixes #230 🦕