Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

Conversation

@santiagotoscanini
Copy link

@santiagotoscanini santiagotoscanini commented Aug 17, 2021

fix: remove unnecessary double quotes

Remove unnecessary double quotes (i.e: "...must" "be set...")

in google/cloud/automl_v1beta1/services/tables/tables_client.py

Fixes #230 🦕

Remove unnecessary double quotes (i.e: "...must" "be set...")

in `google/cloud/automl_v1beta1/services/tables/tables_client.py`
@santiagotoscanini santiagotoscanini requested a review from a team as a code owner August 17, 2021 18:34
@product-auto-label product-auto-label bot added the api: automl Issues related to the googleapis/python-automl API. label Aug 17, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 17, 2021
@santiagotoscanini santiagotoscanini changed the title Fix unnecessary double quotes on tables_client.py fix: unnecessary double quotes on tables_client.py Aug 17, 2021
@santiagotoscanini santiagotoscanini changed the title fix: unnecessary double quotes on tables_client.py fix: remove unnecessary double quotes Aug 17, 2021
@busunkim96 busunkim96 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 17, 2021
@busunkim96
Copy link
Contributor

Thank you for the patch @santiagotoscanini!

@busunkim96 busunkim96 removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 17, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2021
@tseaver
Copy link
Contributor

tseaver commented Aug 17, 2021

@busunkim96 Is google/cloud/automl_v1beta1/services/tables/tables_client.py not generated?

@santiagotoscanini
Copy link
Author

@busunkim96 Is google/cloud/automl_v1beta1/services/tables/tables_client.py not generated?

Does the CI fail because of the black linter error on google/cloud/automl_v1beta1/services/tables/tables_client.py?

@tseaver
Copy link
Contributor

tseaver commented Aug 18, 2021

@santiagotoscanini Yes, it does. Can you run nox -s blacken in your local clone, and then commit and push the updated file to this PR?

@santiagotoscanini
Copy link
Author

@tseaver I pushed the file, but the CI seems to be stuck (~3 hours)

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2021
@dandhlee
Copy link
Contributor

@pytest.fixture(scope="function")
    def operation_id():
        client = automl.AutoMlClient()
        project_location = f"projects/{PROJECT_ID}/locations/us-central1"

        generator = client._transport.operations_client.list_operations(
            project_location, filter_=""
        ).pages
        page = next(generator)
>       operation = page.next()
E       AttributeError: 'Page' object has no attribute 'next'

get_operation_status_test.py:34: AttributeError

Looks unrelated to this change, has there been a breaking change that came in recently? Or did this flake?

@dandhlee dandhlee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2021
@tseaver
Copy link
Contributor

tseaver commented Aug 20, 2021

@dandhlee dandhlee added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: automl Issues related to the googleapis/python-automl API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AutoML: docstring typo in TablesClient

7 participants